[Postgres-xl-developers] regression bug fix(Internet mail)

senhu(胡森) senhu at tencent.com
Mon Oct 16 18:09:34 PDT 2017


Hi,tomas:
    I'll check the postgresql 10 again to see why it does not happen on postgresql. We need
to fix the root cause.

regards
senhu (senhu at tencent.com)


-----邮件原件-----
发件人: Tomas Vondra [mailto:tomas.vondra at 2ndquadrant.com] 
发送时间: 2017年10月17日 0:13
收件人: senhu(胡森); postgres-xl-developers at lists.postgres-xl.org
主题: Re: 答复: 答复: [Postgres-xl-developers] regression bug fix(Internet mail)



On 10/16/2017 03:43 AM, senhu(胡森) wrote:
> Hi,tomas:
> In PostgreSQL, no function called ' split_pathtarget_at_srfs ', this 
> function is particular in PGXL to split pathtargets.
No, it most certainly is not XL-specific function. See

https://github.com/postgres/postgres/blob/REL_10_STABLE/src/backend/optimizer/util/tlist.c#L786

in the PostgreSQL 10 source.

> I think the problem is in this function, not the function '
> add_new_columns_to_pathtarget '. The pathtargets created in '
> split_pathtarget_at_srfs ' are used as groupby columns, but are not 
> set the sortgrouprefs, so groupby can not located the pathtarget.
> 

Not sure. Perhaps your patch is the correct way to fix this. I'm not very familiar with this part of the code, will have to study it a bit more. What I'd like to achieve is fixing the root cause and not just the symptoms.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



More information about the Postgres-xl-developers mailing list