[Postgres-xl-developers] 答复: regression bug fix(Internet mail)

senhu(胡森) senhu at tencent.com
Wed Oct 11 18:32:22 PDT 2017


Hi,tomas:
    In function ' split_pathtarget_at_srfs ', we invoke ' add_new_columns_to_pathtarget ' to
add expressions to pathtarget, but do not set sortgrouprefs of pathtarget. I think it may be better to
set sortgrouprefs here.


regards
senhu (senhu at tencent.com)

-----邮件原件-----
发件人: Tomas Vondra [mailto:tomas.vondra at 2ndquadrant.com] 
发送时间: 2017年10月12日 3:46
收件人: senhu(胡森); postgres-xl-developers at lists.postgres-xl.org
主题: Re: [Postgres-xl-developers] regression bug fix(Internet mail)

Hi senhu,

On 10/10/2017 01:25 PM, senhu(胡森) wrote:
> 
> Hi, all:
> 
>    When I run the case tsrf of regression on latest version of PGXL, I 
> get the error message
> 
> “ORDER/GROUP BY expression not found in targetlist”. It seems like the 
> problem is in function
> 
> ‘split_pathtarget_at_srfs’, add new column to pathtarget just appends 
> the expressions, but do not
> 
> set the sortgrouprefs. I share a patch to set the sortgrouprefs at the 
> end of creation of pathtarget,
> 

Thanks for the patch! I've been wondering what causes this regression failure, so thanks for investigating. I'll review the patch soon.

> I think it may be better to set the sortgrouprefs when creating pathtarget.
> 

Does that mean you think there might be a better way to fix this issue?


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



More information about the Postgres-xl-developers mailing list