[Postgres-xl-developers] pgxc_ctl - reading configuration file

Koichi Suzuki koichi.dbms at gmail.com
Tue Nov 11 00:36:25 PST 2014


Thanks.   I hope another crash fix can be applied to XC (adding pooler
resource release).

Regards;
---
Koichi Suzuki


2014-11-11 15:26 GMT+09:00 Pavan Deolasee <pavan.deolasee at gmail.com>:
>
>
> On Mon, Nov 10, 2014 at 11:25 AM, Koichi Suzuki <koichi.dbms at gmail.com>
> wrote:
>>
>> Looks okay.   It is common to XC.   Do you think XC can also apply this
>> patch?
>
>
> I think so, though I did not test on XC. Please feel free to apply.
>
> Thanks,
> Pavan
>
>
>>
>> ---
>> Koichi Suzuki
>>
>>
>> 2014-11-10 14:28 GMT+09:00 Pavan Deolasee <pavan.deolasee at gmail.com>:
>> > Hello All,
>> >
>> > I noticed that if certain parameters are not set in the pgxc_ctl.conf
>> > file,
>> > the utility uses the default from contrib/pgxc_ctl/pgxc_ctl_bash.c. This
>> > creates all sorts of issues. For example, if the user does not want to
>> > setup
>> > datanode slaves and hence does not set datanodeSlave and related
>> > parameters
>> > in the conf file then they are read from the defaults and "pgxc_ctl init
>> > all" will instead try to set up datanode slaves and thus fail.
>> >
>> > I came up with the attached patch to fix the problem i.e. we should not
>> > read
>> > the defaults if a configuration file is already supplied. I confirmed
>> > that
>> > "pgxc_ctl prepare" still works with the patch. Does this look like a
>> > good
>> > change?
>> >
>> > Thanks,
>> > Pavan
>> >
>> > --
>> > Pavan Deolasee
>> > http://www.linkedin.com/in/pavandeolasee
>
>
>
>
> --
> Pavan Deolasee
> http://www.linkedin.com/in/pavandeolasee




More information about the Postgres-xl-developers mailing list