[Postgres-xl-developers] fix postgres-xl build on FreeBSD

Pavan Deolasee pavan.deolasee at gmail.com
Thu Dec 11 23:35:10 PST 2014


On Thu, Dec 11, 2014 at 1:31 PM, Jov <amutu at amutu.com> wrote:
>
> I will put the patch to pgxl,but the review progress is slow.there is no
> feedback from Mason Sharp for the first patch by now.
>

Hi Jov,

Sorry for the delay. I looked at your patch to fix FreeBSD issues. The
patch looks good except this change.

diff --git a/contrib/pgxc_ctl/make_signature
b/contrib/pgxc_ctl/make_signature
index 04020f3..bdc3d42 100755
--- a/contrib/pgxc_ctl/make_signature
+++ b/contrib/pgxc_ctl/make_signature
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #--------------------------------------------------------------------
 #
 # make_signature

IMHO its better to just revert to "sh" shell instead of using "bash". From
what I understand, bash may not even be installed on some FreeBSD systems.
So I'm proposing to use !/bin/sh since the same is used for couple of other
scripts that PostgreSQL uses and seem to work on all platforms without any
complaints. Can you please verify on FreeBSD and let us know?

Thanks,
Pavan

-- 
Pavan Deolasee
http://www.linkedin.com/in/pavandeolasee
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.postgres-xl.org/private.cgi/postgres-xl-developers-postgres-xl.org/attachments/20141212/e62c7f24/attachment.htm>


More information about the Postgres-xl-developers mailing list